Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set psuade default location with shutil #1133

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Set psuade default location with shutil #1133

merged 3 commits into from
Apr 11, 2023

Conversation

franflame
Copy link
Contributor

Summary/Motivation:

Sets default location for psuade executable if found in the environment

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the copyright and license terms described in the LICENSE.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Apr 11, 2023
sotorrio1
sotorrio1 reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@sotorrio1 sotorrio1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suggest running black on session.py and I'll approve

@codecov
Copy link

codecov bot commented Apr 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.15 ⚠️

Comparison is base (f3ea25f) 34.97% compared to head (ec09867) 34.83%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1133      +/-   ##
==========================================
- Coverage   34.97%   34.83%   -0.15%     
==========================================
  Files         161      161              
  Lines       36334    36334              
  Branches     5943     5943              
==========================================
- Hits        12708    12657      -51     
- Misses      22616    22658      +42     
- Partials     1010     1019       +9
Impacted Files Coverage Δ
foqus_lib/framework/session/session.py 63.95% <100.00%> (ø)

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) April 11, 2023 22:48
@lbianchi-lbl lbianchi-lbl merged commit 44801da into CCSI-Toolset:master Apr 11, 2023
lbianchi-lbl pushed a commit that referenced this pull request Apr 28, 2023
@franflame @lbianchi-lbl
Set psuade default location with shutil (#1133)
56a3300 
* Set psuade default location with shutil

* Format with Black

---------

Co-authored-by: Ludovico Bianchi <lbianchi@lbl.gov>
(cherry picked from commit 44801da)
@boverhof boverhof mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sotorrio1 sotorrio1 sotorrio1 approved these changes

@lbianchi-lbl lbianchi-lbl Awaiting requested review from lbianchi-lbl

Assignees

@franflame franflame

Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
EY23.4.1.K: Automated test coverage i...
Development

Successfully merging this pull request may close these issues.
4 participants
@franflame @sotorrio1 @ksbeattie @lbianchi-lbl